Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'react-tooltip' contains react-dom as a dependency #2869

Closed
jpellizzari opened this issue Sep 26, 2017 · 0 comments
Closed

'react-tooltip' contains react-dom as a dependency #2869

jpellizzari opened this issue Sep 26, 2017 · 0 comments
Assignees
Labels
chore Related to fix/refinement/improvement of end user or new/existing developer functionality component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer

Comments

@jpellizzari
Copy link
Contributor

jpellizzari commented Sep 26, 2017

This should be a peer dependency, not a runtime dependency. This accounts for ~700kb of bundle size, or about 25% of the Scope chunk in service-ui.

From the project's readme:

You can import node_modules/react-tooltip/standalone/react-tooltip.min.js into your page. Please make sure that you have already imported react and react-dom into your page.

My preference would be to remove/replace it, since the project decided not to follow the rules and its only used once in entire project.

@jpellizzari jpellizzari added chore Related to fix/refinement/improvement of end user or new/existing developer functionality component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer labels Sep 26, 2017
@fbarl fbarl self-assigned this Sep 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Related to fix/refinement/improvement of end user or new/existing developer functionality component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer
Projects
None yet
Development

No branches or pull requests

2 participants