Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRI: Add unit tests in probe/cri #3302

Open
lilic opened this issue Aug 7, 2018 · 3 comments · Fixed by #3364
Open

CRI: Add unit tests in probe/cri #3302

lilic opened this issue Aug 7, 2018 · 3 comments · Fixed by #3364
Labels
chore Related to fix/refinement/improvement of end user or new/existing developer functionality k8s Pertains to integration with Kubernetes

Comments

@lilic
Copy link
Contributor

lilic commented Aug 7, 2018

No description provided.

@lilic lilic added k8s Pertains to integration with Kubernetes chore Related to fix/refinement/improvement of end user or new/existing developer functionality labels Aug 7, 2018
@kelkarajay kelkarajay mentioned this issue Oct 1, 2018
Merged
bboreham added a commit that referenced this issue Oct 8, 2018
@bboreham
Merge pull request #3364 from Xivolkar/master
d71a732 
#3302: Absolute basic UT
@bboreham
Copy link
Collaborator

bboreham commented Oct 8, 2018

Reopened since #3364 was "partially fixes..."

@bboreham bboreham reopened this Oct 8, 2018
@dholbach
Copy link
Contributor

dholbach commented Oct 8, 2018

It might be good to add a couple more details about what we want tested here. Ideally high coverage, but maybe some bigger chunks which would help new contributors find their way around?

@gotjosh
Copy link
Contributor

gotjosh commented Oct 13, 2018

I'll be taking a stab at this. As @dholbach mentioned, would be good to have some high-level guidance on what kind of tests should we be aiming for.

@gotjosh gotjosh mentioned this issue Oct 15, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore Related to fix/refinement/improvement of end user or new/existing developer functionality k8s Pertains to integration with Kubernetes
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#3302: Absolute basic Unit Tests for CRI registry kelkarajay/scope
5 participants
@gotjosh @dholbach @satyamz @lilic @bboreham