-
Notifications
You must be signed in to change notification settings - Fork 712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow users to apply a transform to container names #432
Comments
As discussed with @peterbourgon the idea (for now) is to render names based on the container's context. For instance, in the case of ECS, container names are mangled but ECS provides the original container name in a Docker container label: The probes will obtain the container's cloud context and include a Container report metadata entry, say |
@paulbellamy I would be interested to know if this would work well for Kubernetes too. |
A transform would work ok. There's not really a container-specific label that would work well in the container's view. There's just the pod name label, which will be shared between multiple containers. |
Sounds fine.
How will it know this? Is it enough to 'just' use |
I agree with @tomwilkie we should just use the label if present for now. We can use a |
@fons do you think we can close this? I don't think we need anything more general, do we? |
Not for now, I'll close it |
See #413
The text was updated successfully, but these errors were encountered: