Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to apply a transform to container names #432

Closed
tomwilkie opened this issue Sep 3, 2015 · 7 comments
Closed

Allow users to apply a transform to container names #432

tomwilkie opened this issue Sep 3, 2015 · 7 comments
Assignees

Comments

@tomwilkie
Copy link
Contributor

See #413

@2opremio
Copy link
Contributor

2opremio commented Sep 3, 2015

As discussed with @peterbourgon the idea (for now) is to render names based on the container's context. For instance, in the case of ECS, container names are mangled but ECS provides the original container name in a Docker container label: com.amazonaws.ecs.container-name

The probes will obtain the container's cloud context and include a Container report metadata entry, say "provider"="ECS" which the renderer can use to adapt the container name to display (from the com.amazonaws.ecs.container-name) and tweak other presentation details.

@2opremio
Copy link
Contributor

2opremio commented Sep 3, 2015

@paulbellamy I would be interested to know if this would work well for Kubernetes too.

@paulbellamy
Copy link
Contributor

A transform would work ok. There's not really a container-specific label that would work well in the container's view. There's just the pod name label, which will be shared between multiple containers.

@tomwilkie
Copy link
Contributor Author

Sounds fine.

The probes will obtain the container's cloud context and include a Container report metadata entry, say "provider"="ECS"

How will it know this? Is it enough to 'just' use com.amazonaws.ecs.container-name as the name if its present?

@2opremio
Copy link
Contributor

2opremio commented Sep 7, 2015

I agree with @tomwilkie we should just use the label if present for now. We can use a provider metadata entry when/if the cloud-provider-specific rendering gets more sophisticated.

@tomwilkie
Copy link
Contributor Author

@fons do you think we can close this? I don't think we need anything more general, do we?

@2opremio
Copy link
Contributor

Not for now, I'll close it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants