Use label "com.amazonaws.ecs.container-name" to render container names #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2opremio
force-pushed
the
container-name-from-ecs-label
branch
2 times, most recently
from
c344cef to
e81cdb1
Compare
| // Luckily, the ecs-agent provides label | ||
| // "com.amazonaws.ecs.container-name" containing the original Container | ||
| // Definition name, which we will use for rendering. | ||
| // |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
2opremio
force-pushed
the
container-name-from-ecs-label
branch
from
e81cdb1 to
ebefa5e
Compare
|
LGTM |
tomwilkie
added a commit
that referenced
this pull request
Sep 8, 2015
Use label "com.amazonaws.ecs.container-name" to render container names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #432 in the case of Amazon's ECS.