Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing edges between the ECS-demo containers #446

Closed
2opremio opened this issue Sep 4, 2015 · 9 comments
Closed

Missing edges between the ECS-demo containers #446

2opremio opened this issue Sep 4, 2015 · 9 comments
Assignees
Labels
bug Broken end user or developer functionality; not working as the developers intended it

Comments

@2opremio
Copy link
Contributor

2opremio commented Sep 4, 2015

Steps to reproduce.

  1. Launch the scope variant of the ECS demo (which uses scope:latest)

    git clone -b aws-ecs-scope git@github.com:weaveworks/guides.git
    cd guides/aws-ecs
    ./setup
    

    Which should output three urls let's call them u1, u2, u3.

  2. Make sure that the Http Servers are communicating with the Data Producers:

    while true; do 
      for I in u1 u2 u3; do 
        curl $I
      done
    done
  3. Open Scope in any of the three instances (e.g. u1:4040)

    The HttpServer and DataProducers ( the ecs-weave-ecs... containers) should be connected since they are communicating with each other. However they are not.
    screen shot 2015-09-04 at 4 11 28 pm

@2opremio
Copy link
Contributor Author

2opremio commented Sep 4, 2015

In fact, I also expect an edge between all the weavescope containers since every probe is reporting to all the apps.

@tomwilkie
Copy link
Contributor

@2opremio attaching the contents of /api/report and /api/topology/containers to bugs like this will massively help narrow it down.

@tomwilkie tomwilkie added the bug Broken end user or developer functionality; not working as the developers intended it label Sep 5, 2015
@2opremio
Copy link
Contributor Author

2opremio commented Sep 6, 2015

@tomwilkie
Copy link
Contributor

I've figured this out.

My bad.

@tomwilkie tomwilkie self-assigned this Sep 7, 2015
@2opremio
Copy link
Contributor Author

2opremio commented Sep 7, 2015

Great that you figured it out. Out of curiosity, can you elaborate on what's causing it?

@tomwilkie
Copy link
Contributor

I thought I had it but I didn't. Sorry. Still working on it.

@peterbourgon
Copy link
Contributor

Any update here? This is the only remaining release-blocker.

@tomwilkie
Copy link
Contributor

The attached or fixes some issues but doesn't fix it 100%.

I've got two test cases: cross host communication over the weave network,
and cross host communication via docker port mapping. (1) works now, (2)
doesn't.

I don't know why it doesn't work yet.

Feel free to review the pr, I see no reason why it can't go in.

On Saturday, September 12, 2015, Peter Bourgon notifications@github.com
wrote:

Any update here? This is the only remaining release-blocker.


Reply to this email directly or view it on GitHub
#446 (comment).

@tomwilkie
Copy link
Contributor

This is mostly fixes - pseudo nodes are working again, and short lived connections from containers to the internet are working.

But the short lived connection code doesn't deal with connections coming from the internet, as they go to the hosts IP, not the containers. We know the port mapping for containers, so we should be able to fix this. See #493

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Broken end user or developer functionality; not working as the developers intended it
Projects
None yet
Development

No branches or pull requests

3 participants