circle.yml: deploy on a personal hub account #1055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @alban; I'd be tempted to update the |
|
@tomwilkie that's sound good to me as well. I'll try that. |
alban
force-pushed
the
alban/build-2
branch
3 times, most recently
from
a463c9a to
c99400e
Compare
I would to do some changes in Scope and test my changes in Kubernetes, following the guide on: https://github.com/weaveworks/scope#using-weave-scope-with-kubernetes For that, I need a Docker image of Scope hosted on a Docker hub and reference that Docker image in my Kubernetes resource yaml file. Instead of building Scope on my laptop and pushing it manually on my Docker Hub account, I am using my CircleCI account to do this automatically. This patch fixes the deployment target in circle.yml. It uses the environment variable $DOCKER_USER from the CircleCI settings to guard against unintended deployment. As before, only the "master" branch will trigger the deployment. This change should not impact the build of the official Scope Docker image.
|
This new version seems to work for me. |
tomwilkie
added a commit
that referenced
this pull request
Feb 29, 2016
circle.yml: deploy on a personal hub account
|
@tomwilkie did it get pushed to the correct place?
|
|
mmm yes, it did not. I forgot circle has my credentials. We'll need another environment variable... |
|
I'm preparing another PR to fix this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would to do some changes in Scope and test my changes in Kubernetes,
following the guide on:
https://github.com/weaveworks/scope#using-weave-scope-with-kubernetes
For that, I need a Docker image of Scope hosted on a Docker hub and
reference that Docker image in my Kubernetes resource yaml file. Instead
of building Scope on my laptop and pushing it manually on my Docker Hub
account, I am using my CircleCI account to do this automatically.
This patch adds a deployment target in circle.yml. It uses the
environment variable $DEPLOY_PRIVATE_HUB_BRANCH from my CircleCI
settings and any push on a branch with a name matching ".*master" (the
branch name must end with "master") will trigger the deployment.
This change should not impact the build of the official Scope Docker
image because $DEPLOY_PRIVATE_HUB_BRANCH is not defined in the official
CircleCI settings (https://circleci.com/gh/weaveworks/scope).