Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make app-store's topologies object immutable #1167

Merged
merged 1 commit into from
Mar 15, 2016
Merged

Conversation

davkal
Copy link
Contributor

@davkal davkal commented Mar 14, 2016

  • refactoring, functionality should be the same
  • extracted some functions into utils/topology-utils.js
  • adapted tests

return ['Nodes: ' + topology.stats.node_count,
'Connections: ' + topology.stats.node_count].join('\n');
return ['Nodes: ' + topology.get('stats').get('node_count'),
'Connections: ' + topology.get('stats').get('node_count')].join('\n');

This comment was marked as abuse.

@foot
Copy link
Contributor

foot commented Mar 15, 2016

Looks good TM

@foot foot assigned davkal and unassigned foot Mar 15, 2016
* refactoring, functionality should be the same
* adapted tests
@davkal davkal force-pushed the immutablejs-topology branch from f30c953 to 3f8a26d Compare March 15, 2016 09:02
davkal added a commit that referenced this pull request Mar 15, 2016
Make app-store's topologies object immutable
@davkal davkal merged commit a9d53bc into master Mar 15, 2016
@davkal davkal deleted the immutablejs-topology branch March 15, 2016 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants