Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report hostname and version in probe struct, and version in host node. #1377

Merged
merged 2 commits into from
Apr 26, 2016

Conversation

tomwilkie
Copy link
Contributor

Fixes #1322

@tomwilkie
Copy link
Contributor Author

@paulbellamy It occurs to me now that we could get rid of report.Probes and constitute all the information from the Host nodes. WDYT?

@paulbellamy
Copy link
Contributor

So you'd add probe_id, probe_version, and last_seen to hosts?

@tomwilkie
Copy link
Contributor Author

This PR already adds scope_version to the host node, but yet. Don't need to add last seen, can just use a timestamp from latest. Or be explicit.

@paulbellamy
Copy link
Contributor

Sounds fine. Explicit is probably easier to work with, but slightly redundant.

@tomwilkie tomwilkie self-assigned this Apr 25, 2016
@@ -1,7 +1,7 @@
.PHONY: all deps static clean client-lint client-test client-sync backend frontend shell lint

# If you can use Docker without being root, you can `make SUDO= <target>`
SUDO=$(shell (echo "$$DOCKER_HOST" | grep "tcp://" >/dev/null) || echo "sudo -E")
SUDO=$(shell (docker info >/dev/null) || echo "sudo -E")

This comment was marked as abuse.

@tomwilkie tomwilkie force-pushed the 1322-probe-name-and-version branch from 7027789 to b05ef74 Compare April 26, 2016 08:25
@tomwilkie tomwilkie assigned paulbellamy and unassigned tomwilkie Apr 26, 2016
@tomwilkie
Copy link
Contributor Author

@paulbellamy PTAL

@paulbellamy paulbellamy merged commit 6c491c7 into master Apr 26, 2016
@paulbellamy paulbellamy deleted the 1322-probe-name-and-version branch April 26, 2016 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants