-
Notifications
You must be signed in to change notification settings - Fork 712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ECS instructions and badge to README #1392
Conversation
Can we put the badge with the launch instructions? It doesn't match the other badges, which looks kinda naff. Also, @abuehrle FYI these will need to be incorporated into the new docs. |
I knew the badge could be controversial :)
You mean the colors? I know, but I thought it would make the installation even more frictionless and self-explanatory for those familiar with cloud-formation (i.e. no need to even look for how to deploy on AWS, just click the button). I could make it match the other badges but it would make it would fail its purpose (it wouldn't be as recognizable anymore).
Yes please. We should include the documentation of the AMIs (and by extension CloudFormation deployments) https://github.com/weaveworks/integrations/blob/master/aws/ecs/README.md |
Isn't the badge just a link to the ecs docs? I agree it looks a bit naff. |
I will remove it then |
Maybe replace with a more obvious link to the guide in the aws section? |
On a related note, our readme is getting quite long. Maybe a table of contents? |
I've incorporated the readme into the new docs, see #1416 . This needs adding to the restructured docs, though. |
I think that the link link to the cloud formation template in the aws section is pretty clear. |
No description provided.