Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ECS instructions and badge to README #1392

Merged
merged 2 commits into from
May 3, 2016
Merged

Add ECS instructions and badge to README #1392

merged 2 commits into from
May 3, 2016

Conversation

2opremio
Copy link
Contributor

No description provided.

@tomwilkie
Copy link
Contributor

Can we put the badge with the launch instructions? It doesn't match the other badges, which looks kinda naff.

Also, @abuehrle FYI these will need to be incorporated into the new docs.

@2opremio
Copy link
Contributor Author

2opremio commented Apr 28, 2016

I knew the badge could be controversial :)

It doesn't match the other badges, which looks kinda naff.

You mean the colors? I know, but I thought it would make the installation even more frictionless and self-explanatory for those familiar with cloud-formation (i.e. no need to even look for how to deploy on AWS, just click the button).

I could make it match the other badges but it would make it would fail its purpose (it wouldn't be as recognizable anymore).

Also, @abuehrle FYI these will need to be incorporated into the new docs.

Yes please. We should include the documentation of the AMIs (and by extension CloudFormation deployments) https://github.com/weaveworks/integrations/blob/master/aws/ecs/README.md

@paulbellamy
Copy link
Contributor

Isn't the badge just a link to the ecs docs? I agree it looks a bit naff.

@2opremio
Copy link
Contributor Author

2opremio commented May 3, 2016

I will remove it then

@paulbellamy
Copy link
Contributor

Maybe replace with a more obvious link to the guide in the aws section?

@paulbellamy
Copy link
Contributor

On a related note, our readme is getting quite long. Maybe a table of contents?

@abuehrle
Copy link
Contributor

abuehrle commented May 3, 2016

I've incorporated the readme into the new docs, see #1416 . This needs adding to the restructured docs, though.

@2opremio
Copy link
Contributor Author

2opremio commented May 3, 2016

Maybe replace with a more obvious link to the guide in the aws section?

I think that the link link to the cloud formation template in the aws section is pretty clear.

@2opremio 2opremio merged commit 3c707da into master May 3, 2016
@2opremio 2opremio deleted the ecs-docs branch May 3, 2016 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants