Don't attribute conntracked connections to k8s pause containers. #1415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -216,6 +216,12 @@ func MapContainer2IP(m report.Node, _ report.Networks) report.Nodes { | |||
| return report.Nodes{} | |||
| } | |||
|
|
|||
| // if this container doesn't make connections, we can ignore it | |||
| _, doesntMakeConnections := m.Latest.Lookup(kubernetes.DoesNotMakeConnection) | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
tomwilkie
force-pushed
the
dont-join-ips-with-pause-containers
branch
from
32e0849 to
1c5f0ac
Compare
|
@paulbellamy PTAL |
|
Might need rebase, but LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains #1412; you may want to review in one piece (or not) - up to you.