Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deployment and Replica Set views #1436

Merged
merged 4 commits into from
May 9, 2016
Merged

Deployment and Replica Set views #1436

merged 4 commits into from
May 9, 2016

Conversation

paulbellamy
Copy link
Contributor

Fixes #1372

@paulbellamy paulbellamy force-pushed the 1372-deployment-view branch from 84067e0 to 0341c6a Compare May 5, 2016 15:06
@paulbellamy paulbellamy changed the title WIP -- Deployment and Replica Set views Deployment and Replica Set views May 5, 2016
tomwilkie
tomwilkie reviewed May 5, 2016
View reviewed changes
probe/kubernetes/meta.go
)

// Meta represents a metadata information about a Kubernetes object
type Meta interface {

This comment was marked as abuse.

Sign in to view

@tomwilkie
Copy link
Contributor

I think we should either include a replication controller view, or include replication controllers in replica sets.

People still have replication controllers. Like us.

tomwilkie
tomwilkie reviewed May 5, 2016
View reviewed changes
probe/kubernetes/deployment.go

// These constants are keys used in node metadata
const (
DeploymentID = "kubernetes_deployment_id"

This comment was marked as abuse.

Sign in to view

@tomwilkie
Copy link
Contributor

Looks good so far! I'll work on controls for this tomorrow.

@tomwilkie tomwilkie assigned paulbellamy and unassigned tomwilkie May 5, 2016
@paulbellamy paulbellamy force-pushed the 1372-deployment-view branch from 0341c6a to ff8ac03 Compare May 6, 2016 09:09
@paulbellamy
Copy link
Contributor Author

paulbellamy commented May 6, 2016 •
edited
Loading

  • Also, need to check this with multiple nodes, as the deployments/replicasets/services will get reported multiple times

@tomwilkie
Copy link
Contributor

GKE ftw

On Fri, May 6, 2016 at 10:37 AM, Paul Bellamy notifications@github.com
wrote:

Also, need to check this with multiple nodes, as the
deployments/replicasets/services will get reported multiple times

—
You are receiving this because you were assigned.
Reply to this email directly or view it on GitHub
#1436 (comment)

@paulbellamy paulbellamy force-pushed the 1372-deployment-view branch 3 times, most recently from ce22676 to 16f5439 Compare May 6, 2016 15:05
@tomwilkie
Copy link
Contributor

@paulbellamy I just deployed this on GKE.

It looks really good.

tomwilkie
tomwilkie reviewed May 6, 2016
View reviewed changes
probe/kubernetes/meta.go
}

// MetaNode gets the node metadata
func MetaNode(m Meta, id string) report.Node {

This comment was marked as abuse.

Sign in to view

@tomwilkie
Copy link
Contributor

Other than the nit, LGTM

@paulbellamy paulbellamy force-pushed the 1372-deployment-view branch from 16f5439 to 94ddc30 Compare May 9, 2016 08:05
@paulbellamy paulbellamy force-pushed the 1372-deployment-view branch from 94ddc30 to d0633d0 Compare May 9, 2016 08:19
@paulbellamy paulbellamy merged commit c749bb9 into master May 9, 2016
@paulbellamy paulbellamy deleted the 1372-deployment-view branch May 9, 2016 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@paulbellamy paulbellamy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulbellamy @tomwilkie