Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scope slow: improve error messages for debugging #1534

Merged
merged 3 commits into from
May 22, 2016

Conversation

alban
Copy link
Contributor

@alban alban commented May 22, 2016

I often have the following error messages:

Host reporter took longer than 1s
Endpoint reporter took longer than 1s
Process reporter took longer than 1s
Docker reporter took longer than 1s

With this patch, the messages are more descriptive. Examples:

Process reporter took 1.399966061s (longer than 1s)
Endpoint reporter took 4.100178596s (longer than 1s)
Topology tagger took 1.897464894s (longer than 1s)

I also repeatedly have the following, sometimes flooding the output:

docker container: dropping stats.
docker container: dropping stats.
docker container: dropping stats.

I increased the buffer.

Finally, I use another mirror than dl-4.alpinelinux.org because the server is down and this breaks my builds on circleci.

/cc @alepuccetti

alban added 3 commits May 22, 2016 17:29
Attempt to avoid the following message:
docker container: dropping stats.
The logs contains the following messages:

Process reporter took longer than 1s
K8s reporter took longer than 1s
Docker reporter took longer than 1s
Endpoint reporter took longer than 1s

This patch prints how long it takes.
@tomwilkie
Copy link
Contributor

LGTM; although I'd be keen to find out why everything is so slow on your machine - we seldom see these messages.

@tomwilkie tomwilkie merged commit 42ad3aa into weaveworks:master May 22, 2016
@alban
Copy link
Contributor Author

alban commented May 22, 2016

Thanks!

I don't know why this is slow. I'm also interested to find out why. This was on my laptop (Fedora, Thinkpad X220, i7 processor). I am running Docker & Scope inside an OpenShift VM with Vagrant (libvirt, qemu). Docker uses the dm storage backend with the option dm.blkdiscard=false (workaround for kinvolk/demo#11).

@2opremio
Copy link
Contributor

Related: #1379

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants