Helper for reading & writing from binary #1600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we factor out https://github.com/weaveworks/scope/blob/master/app/router.go#L121 as well? Would need to support JSON. Otherwise LGTM. |
|
I did the refactoring. Basically I make |
| return nil | ||
| } | ||
|
|
||
| // ReadBinary reads into a Report from a gzipped msgpack. |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
PTAL. |
| if codecHandle != nil { | ||
| decoder = codec.NewDecoder(r, codecHandle).Decode | ||
| } else { | ||
| decoder = gob.NewDecoder(r).Decode |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
@tomwilkie @rade PTAL. |
|
LGTM but the build is failing for a reason that seems related... |
|
The test was for gob support, which this branch removes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a couple of places where we had said in code that reports are serialized as compress msgpacks. This patch formalizes that convention by providing an API.
I'm working on another PR where I re-use this API in a different place.
There are a bunch of places in tests that could probably also be changed.
This change is