Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't prepend scope launch with sudo #1606

Merged
merged 4 commits into from
Jul 5, 2016
Merged

Conversation

2opremio
Copy link
Contributor

Fixes #1594

@foot
Copy link
Contributor

foot commented Jul 4, 2016

Nice one! Shell script :wizard:!

Still works w/out sudo for me on osx. Don't think can test sudo w/ tls etc

README.md needs updating too.

@2opremio
Copy link
Contributor Author

2opremio commented Jul 4, 2016

Don't think can test sudo w/ tls etc

Does docker check for TLS when using unix sockets? I guess it does, but you are right, we probably don't want to check that from the shellscript.

README.md needs updating too.

Will fix. Thanks

@2opremio 2opremio force-pushed the 1594-no-sudo-for-launch branch from 3edd4c0 to 3b74ea2 Compare July 4, 2016 17:22
@2opremio 2opremio force-pushed the 1594-no-sudo-for-launch branch from 3b74ea2 to 59ec3b8 Compare July 4, 2016 17:23
@tomwilkie
Copy link
Contributor

Still some occurances of sudo that need fixing:

Toms-MacBook-Pro:scope twilkie$ f "sudo scope"
./experimental/kubernetes/install-scope.bash:    remote $h "sudo scope stop ; sudo DOCKER_BRIDGE=cbr0 scope launch --probe.docker.bridge cbr0 --probe.kubernetes true"
./experimental/kubernetes/install-scope.bash:    remote $h "sudo scope stop ; sudo DOCKER_BRIDGE=cbr0 scope launch --no-app --probe.docker.bridge cbr0 kubernetes-master"
./site/introducing.md:    sudo scope launch

Otherwise LGTM

@2opremio
Copy link
Contributor Author

2opremio commented Jul 5, 2016

@tomwilkie experimental/kubernetes/install-scope.bash seems to use sudo for a reason.

It's not documentation but an outdated script for GCE, which frankly I think we should remove since that's not the way to install scope in kubernetes. I will create a different PR to remove it.

@tomwilkie
Copy link
Contributor

experimental/kubernetes/install-scope.bash seems to use sudo for a reason.

alright no worries. @jml is keen on deleting all of experimental...

@2opremio 2opremio merged commit 74e5086 into master Jul 5, 2016
@2opremio 2opremio deleted the 1594-no-sudo-for-launch branch July 5, 2016 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants