Fixes network bars position when a node is selected. #1667
Conversation
Bar position should be a function of node size! Note: This is still an estimated position though it looks fine. Would be nice to take into account size of labels (foreignObjects). The transforms (for "undoing" the canvas zoom level) are a bit hectic here and would be really nice to pull out and put in a wrapper...)
|
Not working for varied node sizes on the canvas (e.g. if you start w/ a very small browser window...). Poking... |
Positioning the bar in the middle of flowing text is a bit tricky.
|
Moves bar position
|
|
Bar has moved above label as it was a bit tricky aligning it accurately in the middle of the text blob. |
|
don't you end up with an awkward gap between node and text when not showing networks? |
|
No, you get a gentle "bump" when enabling/disabling the networks overlay. I don't think its too jarring. Animating it could improve it further. |
|
tried the branch. The "bump" is fine. animating it would be nice but not essential. HOWEVER, on firefox the bar overlaps with the text. and on Chrome it is very close to the text, much closer than on your screen shot above...
|
|
Thanks for testing it. Testing out ff.. |
- Center it vertically properly.
|
Can do with another test! :) |
|
LGTM. Though I cannot comment on the code. |
|
Code looks fine. |
Bar position should be a function of node size!
Note: This is still an estimated position though it looks fine. Would be
nice to take into account size of labels (foreignObjects). The
transforms (for "undoing" the canvas zoom level) are a bit hectic here
and would be really nice to pull out and put in a wrapper...
Fixes #1663