Add support for table based controls #1818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* if a node table has `controls` they will be rendered in a row * controls need the to be of the same structure as node-level controls * control errors are not shown
| renderControls(controls) { | ||
| return ( | ||
| <div className="node-details-labels-controls"> | ||
| {sortBy(controls, 'rank').map(control => <NodeDetailsControlButton |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
How to test this, checkout the ref'd version of scope, make, start plugin? Will give that a goo. |
|
Ah, the controls are still in the normal place in the branch. |
|
Code LGTM, unsure how to test, maybe it will need a tweak at BE/FE integration anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the next version of the UI for #1769.
controlsthey will be rendered in a rowExample:
The backend for this is to follow. This PR can be merged without the backend being ready.