Be more strict when snooping DNS over TCP traffic #1897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2opremio
force-pushed
the
stricter-dns-over-tcp-snooping
branch
2 times, most recently
from
f9da295 to
fdef4ca
Compare
2opremio
force-pushed
the
stricter-dns-over-tcp-snooping
branch
from
fdef4ca to
45a9367
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting non-DNS traffic on TCP port 53 was causing the parser to flood the logs with errors (it happened in Weave Cloud, Prometheus is incorrectly sending http requests).
This makes DNS traffic identification a bit more robust and strict, enforcing our relaxation of only considering self-contained TCP segments.