Add graph complexity check on page load #1994
Conversation
jpellizzari
force-pushed
the
1721-high-node-count
branch
from
1782077 to
abbd4a9
Compare
jpellizzari
force-pushed
the
1721-high-node-count
branch
from
abbd4a9 to
0962cb3
Compare
| @@ -34,7 +34,8 @@ describe('NodeDetails', () => { | |||
| details = {label: 'Node 1'}; | |||
| const c = TestUtils.renderIntoDocument( | |||
| <Provider store={configureStore()}> | |||
| <NodeDetails nodes={nodes} | |||
| <NodeDetails topologyId="containers" nodes={nodes} | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
jpellizzari
force-pushed
the
1721-high-node-count
branch
from
0962cb3 to
b403733
Compare
| @@ -33,6 +34,7 @@ export const initialState = makeMap({ | |||
| gridSortedDesc: null, | |||
| highlightedEdgeIds: makeSet(), | |||
| highlightedNodeIds: makeSet(), | |||
| initialPageLoad: true, | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
| @@ -1,2 +1,3 @@ | |||
|
|
|||
| export const EDGE_ID_SEPARATOR = '-'; | |||
| export const GRAPH_COMPLEXITY_THRESH = 500; | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
Code looks good. One more thing: if Scope has been used before, the view mode may be stored in localStorage (see router-utils.js and storage-utils.js). Should we then take those values, or still check for the graph complexity? |
|
@davkal Since the graph could have gotten more complex from one browser session to the next, I think we should switch to the table mode no matter what the URL or localStorage says. |
jpellizzari
force-pushed
the
1721-high-node-count
branch
4 times, most recently
from
fcdc97f to
87d5ae8
Compare
|
LGTM |
jpellizzari
force-pushed
the
1721-high-node-count
branch
from
87d5ae8 to
ee0bb8e
Compare
Fix for #1721 .
When the page is loaded, the first received topology will trigger a check to see if the graph will be too complex to render. If so, the view will switch to the table view. The complexity check formula:
(currentTopology.stats.node_count * (2 * currentTopology.stats.edge_count)) > 500The user can switch to the graph view at any time. This logic only applies at page load. To test with a high node count (on linux):
nc -lk 1122 & for i in $(seq 1 300) ; do nc localhost 1122 & done@davkal Let me know what you think.