Use newly-created 'common' repo #2061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulbellamy
suggested changes
Dec 6, 2016
|
I don't know. |
|
Running |
|
I've made a totally new PR (#2062) that does PTAL. |
Closed
paulbellamy
approved these changes
Dec 7, 2016
|
Extra vendoring can be explained by weaveworks/common including tools, which has a bunch of go stuff, which you've pulled in the libraries for. Its not a big deal. |
|
#2066 talks a bit about that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2509
This means we can re-use this code in other weave repos without having to depend on scope.