Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-applied "Graph layout optimizations" #2180

Merged
merged 2 commits into from
Feb 3, 2017

Conversation

fbarl
Copy link
Contributor

@fbarl fbarl commented Feb 2, 2017

Brings back the reverted changes from #2128 and introduces a fix for node labels rendering on Firefox.

@fbarl fbarl self-assigned this Feb 2, 2017
@fbarl fbarl requested a review from foot February 2, 2017 14:37
@foot
Copy link
Contributor

foot commented Feb 3, 2017

LGTM!

  • Default zoom for small layouts (e.g. 2-3 nodes) is very high. I understand the zoom is set so that the nodes fit + 10% border. This works great for large layouts. Too accomodate smaller ones we could perhaps Math.min(calculatedZoomWith10%Border, aNiceAestheticNodeZoom);

@fbarl fbarl force-pushed the reapply-graph-layout-optimizations branch from e95b702 to 2b4ba32 Compare February 3, 2017 16:07
@fbarl
Copy link
Contributor Author

fbarl commented Feb 3, 2017

@foot, I did the change you proposed, essentially with aNiceAestheticNodeZoom = maxZoomScale / 2 and it does look better :)

@fbarl fbarl merged commit 43cb754 into master Feb 3, 2017
@2opremio 2opremio deleted the reapply-graph-layout-optimizations branch February 3, 2017 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants