Fix help menu not opening from 'search' hint #2230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bowenli Could you review pls? |
|
I'm earmarking the caution icon for this: #2139 so let's keep the bug for now. |
|
Pls squash commits |
|
Each of those commits is a separate change that is unrelated to the others. I would like to keep those commits so that they can be rolled back individual if necessary. |
jpellizzari
force-pushed
the
2227-search-help
branch
from
919b562 to
f60c7c0
Compare
|
Removed the icon change |
|
lgtm. your circleci is failing though. |
|
Master be broken.
…On Fri, Feb 10, 2017 at 3:33 PM Bowen Li ***@***.***> wrote:
lgtm. your circleci is failing though.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2230 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACrCUZ9Al8GLvT4eHpd4Uv1SJAF-YPTHks5rbPPOgaJpZM4L9xOL>
.
|
jpellizzari
force-pushed
the
2227-search-help
branch
from
f60c7c0 to
8e601dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #2227
Fixes the issue where the help menu wasn't opening unless there was text in the field. Also changed the debug menu icon to a 'warning' icon (the bug didn't make sense anymore).