-
Notifications
You must be signed in to change notification settings - Fork 712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show loading indicator on topology changes #2232
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@simon Could you take a look por favor? |
jpellizzari
force-pushed
the
1804-loading-topologies
branch
from
February 13, 2017 17:54
aa550a8
to
404f0fc
Compare
fbarl
reviewed
Feb 14, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two comments about the UI:
- When you are in the graph view mode and you click on the topology that's already selected, the loader shows up on top of the graph that is already there. One solution here would be to simply move your added line(s) into the
if
-clause above, so thatnodesLoaded
is set to false only when the topology actually changes. As a side note, I'd also extract all this shared code betweenCLICK_SHOW_TOPOLOGY_FOR_NODE
andCLICK_TOPOLOGY
into aswitchTopology
helper, just because there's a lot of repeated logic. - Switch to the table mode happens now every time I change back to a big topology (instead of just the first time), which I think can be slightly annoying. This is because of the condition in line
521
which I think we could be fixed easily if we also add a booleannodesLoadedFirstTime
or something like that to the global state... or perhaps you can find a more elegant solution.
jpellizzari
force-pushed
the
1804-loading-topologies
branch
from
February 15, 2017 05:39
b44e682
to
58fa1c9
Compare
@fbarl Updated |
fbarl
approved these changes
Feb 15, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This was referenced Feb 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #1804
When a user changes topologies via click on the topology filter, or by clicking 'SHOW IN ', the loading indicator will show after 1 second. It will be cleared by the first nodes delta data arriving via websockets.