Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

circle.yml: Fix ui upload step so it doesn't build twice #2266

Merged
merged 1 commit into from
Feb 22, 2017

Conversation

ekimekim
Copy link
Contributor

There are two source checkouts in circle, and we were building in the wrong one
(ie. not the one where the earlier build happened). This was wasteful at best
and buggy at worst due to build differences.

Fixes #1918

There are two source checkouts in circle, and we were building in the wrong one
(ie. not the one where the earlier build happened). This was wasteful at best
and buggy at worst due to build differences.
@foot
Copy link
Contributor

foot commented Feb 22, 2017

LGTM after circle passes!

@ekimekim ekimekim merged commit 045aaa5 into master Feb 22, 2017
@ekimekim ekimekim deleted the mike/fix-ui-circle-rebuild branch February 22, 2017 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants