-
Notifications
You must be signed in to change notification settings - Fork 712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial version of the resource view #2296
Conversation
10433f0
to
b31443a
Compare
8d329b3
to
2b92f25
Compare
cedfc8b seems unrelated to this PR. Furthermore, it appears to contain changes - the logo.js update - unrelated to its supposed purpose. |
@rade In that commit I actually reverted the changes to |
just do a separate PR for disabling SVG saving in table mode. |
136f534
to
b26f5fe
Compare
60bc152
to
f77d9cb
Compare
I have addressed all the UI feedback I got for this story:
This was fixed automatically as I made the resource view for each topology have HOSTS as the base layer. Since that topology has no filters, all hosts are always loaded at once and since they are the base layer, they determine max width of the layout, so it doesn't get resized after it's rendered once.
As we agreed, I (temporarily) made all the topologies show all three layers, so there is actually no difference in what they are displaying now (and therefore I'm using the same zoom caching key across all the topologies in the resource view now).
I added a tooltip with a short summary.
I hardcoded CPU and Memory as the only metrics for the resource view, which enabled me to always pin a default metric in the resource view when none (or a different one) was previously pinned.
Changed consumed to used. I moved the metric selector to the top, just below the view mode selector in all the views, making it more consistent. If you want, you can take a final look at the resource view behaviour. |
9d8eb39
to
dd7107b
Compare
dd7107b
to
3dc4e9d
Compare
First step towards resolving #2242.
Pretty much copying the layout from the slides with some metrics that are already supported by backend:
Changes
gridMode
global state boolean withtopologyViewMode
string (which can now have valuestopo
,grid
,resource
).availableCanvasMetrics
andpinnedMetric
, to simplify the transition between topologies in the resource viewAction items (by priority)
a. Search bar should be shown and functioning - Resource view - make nodes searchable #2384
b. Topology options should be shown and working - Resource view - show topologies filters in bottom-left corner #2385
Other UI/optimizations ideas