Move RenderableNode and DetailedNode into render/ #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Rows: []report.Row{ | ||
| {"Host name", serverHostName, ""}, | ||
| Rows: []Row{ | ||
| {"Host name", serverHostID, ""}, |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
Gimme another poke when those are resolved... |
tomwilkie
force-pushed
the
228-more-moves
branch
2 times, most recently
from
ca17cdc to
95ac4bd
Compare
|
Sorry about that; the origin tests were originally using the report fixture from report/report_fixture_test.go, but I changed them to use the one from render_test.go. I'll canonicalise a report fixture for the render module in a future changeset. |
| @@ -1,4 +1,4 @@ | |||
| package report_test | |||
| package render | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
tomwilkie
force-pushed
the
228-more-moves
branch
from
95ac4bd to
228440b
Compare
tomwilkie
force-pushed
the
228-more-moves
branch
from
228440b to
2a4a33f
Compare
|
Thanks for making it more comprehensive. LGTM! |
tomwilkie
added a commit
that referenced
this pull request
Jun 16, 2015
Move RenderableNode and DetailedNode into render/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A continuation of #228