-
Notifications
You must be signed in to change notification settings - Fork 712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Produce containers topology from endpoints via processes #248
Conversation
8b57567
to
5f57054
Compare
major = fmt.Sprintf("%s:%s", m["addr"], m["port"]) | ||
minor = fmt.Sprintf("%s (%s)", m[report.HostNodeID], m["pid"]) | ||
rank = m["pid"] | ||
) |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
From discussion:
|
@peterbourgon I think this is ready to go now. You were right about not-propagating-NMDs for derived nodes. |
OK let me do another parse... |
// MapFunc is anything which can take an arbitrary RenderableNode and | ||
// return another RenderableNode. | ||
// | ||
// As with LeadMapFunc, if the final output parameter is false, the node |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
Okay, I follow everything. After those edits, LGTM. |
…adata' -to AggregateMetadata
Address feedback; thanks! there are 2 problems with the PR as it stands: |
Produce containers topology from endpoints via processes
With this change, the process topology is used to produce the containers topology - fixes #228.
Changes:
The meat of the review is the new render.Map type, the mapping functions and render/topologies.go (naming suggestions?).
Left TODO:
Note I won't be going the container image topology in this PR, so "the old way" of producing renderablenodes will be around for a little longer.