Canvas zoom control #2513
Merged
Canvas zoom control #2513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
fbarl
force-pushed
the
try-zoom-slider
branch
2 times, most recently
from
dde4437 to
4b553f7
Compare
|
@fbarl Re: CSS not being proxied: you stumbled on one of the limitations of our LocalModuleProxy. It only works if all dependencies are present in the service-ui. I haven't checked to see if webpack 2 exposes any new APIs that we can use to make that a nicer integration. |
jpellizzari
approved these changes
May 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2321 and makes #2420 redundant.
Changes
ZoomableCanvas.Note
service-uiproxying, as~rc-slider/dist/rc-slider.csswouldn't be found from in Service UI. Runningnpm install rc-sliderinside theservice-ui/clientfolder did it for me, but I wonder why this dependency wasn't pulled from the local Scope'spackage.json. Maybe it has to do with Webpack 2 vs. Webpack 1 (@foot had a similar issue withxterm). @jpellizzari I tried fixing this but couldn't figure it out - do you have any ideas what might be causing the issue?