Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update github.com/weaveworks/common & dependencies (needs go1.8) #2570

Merged
merged 1 commit into from
Jun 29, 2017

Conversation

rndstr
Copy link
Contributor

@rndstr rndstr commented Jun 7, 2017

introduces weaveworks/common#42


Bumped all packages that make the build fail:

gvt update github.com/golang/protobuf/proto
gvt fetch github.com/golang/protobuf/ptypes
gvt fetch google.golang.org/genproto/googleapis/rpc/status
gvt update google.golang.org/grpc/status
gvt update google.golang.org/grpc/transport
gvt update golang.org/x/net/http2

Latest weaveworks/common only compiles on go1.8, scope uses go1.7 right now.

@rndstr rndstr force-pushed the update-weaveworks-common branch 2 times, most recently from f7b7d72 to 1b56c9c Compare June 8, 2017 15:52
@rndstr rndstr changed the title Update github.com/weaveworks/common Update github.com/weaveworks/common & dependencies (needs go1.8) Jun 8, 2017
@rndstr rndstr mentioned this pull request Jun 8, 2017
@bboreham
Copy link
Collaborator

Failing in CI with vendor/github.com/weaveworks/common/middleware/path_rewrite.go:28: undefined: url.PathUnescape

Bumped all packages that make the build fail:

    gvt update github.com/golang/protobuf/proto
    gvt fetch github.com/golang/protobuf/ptypes
    gvt fetch google.golang.org/genproto/googleapis/rpc/status
    gvt update google.golang.org/grpc/status
    gvt update google.golang.org/grpc/transport
    gvt update golang.org/x/net/http2
@rndstr rndstr force-pushed the update-weaveworks-common branch from 1b56c9c to c817ecc Compare June 21, 2017 10:19
@rndstr
Copy link
Contributor Author

rndstr commented Jun 21, 2017

rebased master (with go1.8)

@rndstr rndstr requested review from 2opremio and bboreham June 21, 2017 10:59
@2opremio
Copy link
Contributor

@rndstr ping

@rndstr rndstr merged commit 247c365 into master Jun 29, 2017
@rndstr rndstr deleted the update-weaveworks-common branch June 29, 2017 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants