Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not read tcp6 files if TCP version 6 isn't supported #2604

Merged
merged 1 commit into from
Jun 16, 2017

Conversation

2opremio
Copy link
Contributor

This will help with #2577 when using /proc parsing. Fixing the eBPF connection tracker requeres a separate PR.

@2opremio 2opremio requested a review from ekimekim June 15, 2017 15:13
Copy link
Contributor

@ekimekim ekimekim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, one nit (non-blocking)

func tcp6FileExists() bool {
filename := filepath.Join(procRoot, "self/net/tcp6")
f, err := fs.Open(filename)
if err != nil {

This comment was marked as abuse.

This comment was marked as abuse.

@2opremio 2opremio merged commit 8c0c20f into master Jun 16, 2017
@2opremio 2opremio deleted the 2577-ipv6-disabled-proc branch June 16, 2017 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants