Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

correct nodeSummaryGroupSpec #2631

Merged
merged 2 commits into from
Jun 21, 2017
Merged

correct nodeSummaryGroupSpec #2631

merged 2 commits into from
Jun 21, 2017

Conversation

rade
Copy link
Member

@rade rade commented Jun 21, 2017

make nodeSummaryGroupSpecs only include what's needed

Fixes #2630.

@rade rade requested a review from ekimekim June 21, 2017 17:26
@rade
Copy link
Member Author

rade commented Jun 21, 2017

best reviewed by looking at the two commits individually.

ekimekim
ekimekim approved these changes Jun 21, 2017
View reviewed changes
Copy link
Contributor

@ekimekim ekimekim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for splitting the commits, much easier to read

@rade rade merged commit 6b8a0e4 into master Jun 21, 2017
@rade rade deleted the 2630-correct-nodeSummaryGroupSpec branch July 5, 2017 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekimekim ekimekim ekimekim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rade @ekimekim