simplify connection join #2714
Merged
simplify connection join #2714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This guarantees that the output won't contain bare nodes containing just an id and topology, as produced by ipToNode. Previously this was ensured by calling convention, now it's ensured by construction.
We always join with the original renderer and hence all the nodes produced by ipToNode will get their other data, including topology, via that route.
IP nodes are children of the "proper" topology nodes, not the other way round. The former relationship is established in ipToNode.
ekimekim
approved these changes
Jul 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few tweaks to simplify the code.
I've checked that this doesn't change the topology outputs by running before/after comparisons based on a recent Weave Cloud Prod report.