do not back off on timeouts when sending reports #2746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2opremio
reviewed
Jul 25, 2017
| @@ -215,7 +216,11 @@ func (c *appClient) doWithBackoff(msg string, f func() (bool, error)) { | |||
| backoff = initialBackoff | |||
| continue | |||
| } | |||
|
|
|||
| if netErr, ok := err.(net.Error); ok && netErr.Timeout() { | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
rade
force-pushed
the
2745-do-not-backoff-on-timeout
branch
from
c4e991a to
d844f0c
Compare
...since doing so unnecessarily throttles report sending, to the point where the app is receiving reports so infrequently that often it has no data to show. The timeout period itself is sufficient to prevent thrashing. Fixes #2745.
rade
force-pushed
the
2745-do-not-backoff-on-timeout
branch
from
d844f0c to
a5a9180
Compare
2opremio
approved these changes
Jul 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...since doing so unnecessarily throttles report sending, to the point where the app is receiving reports so infrequently that often it has no data to show.
The timeout period itself is sufficient to prevent thrashing.
Fixes #2745.