Fix edges disappearing in graph mode

[fbarl]

Fixes #2850.

It seems that under some circumstances isAnimated prop would turn from false to true after the waypoints would be fixed, so prepareWaypointsForMotion would never be called given how the conditionals were set, giving an empty waypointsMap and consequently an ill-defined spline path for animated edges.

Changes

• Simplified and broadened the conditions for waypointsMap recalculation to make sure they are called when necessary (but not making excessive calls).
• Made helper functions for spring to avoid repeated code.

[foot]

Is there an easy way to repro this one?

[rade]

I see this all the time in Chrome on Linux when I

1. go to https://cloud.weave.works/app/cold-sky-72
2. click 'bug' -> 'Reset your local view state' (this should bring up the table view of 'Controllers')
3. click graph view

The edges show up for a few seconds and then disappear.

[foot]

Perfect, ta.

…

On 14 September 2017 at 09:29, Matthias Radestock ***@***.***> wrote: I see this all the time in Chrome on Linux when I 1. go to https://cloud.weave.works/app/cold-sky-72 2. click 'bug' -> 'Reset your local view state' (this should bring up the table view of 'Controllers') 3. click graph view The edges show up for a few seconds and then disappear. — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#2851 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABV-Mi8Z0d9AHn5CWvlZRDPOZKAUr_Kks5siNXxgaJpZM4PTZ6Z> .

[foot]

Nice one, much better, LGTM