Update ugorji/go/codec #2863
Merged
Update ugorji/go/codec #2863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have you done any backward compatibility testing, i.e. decoding a newly encoded report with the old decoder and decoding an old encoded report with the new decoder? |
Merged
|
Yes, I have checked this with the ugly code in branch |
rade
approved these changes
Oct 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit log talks about all the speed optimisations, but when I ran some tests of msgpack encoding and decoding it was about the same speed as before.
Fixes #2862
Nice that our use of the library doesn't seem to break.