Use a context sensitive route for the popped out terminal.html #2882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Service-ui has learned a new route which corresponds to the existing scope terminal.html route. Both standalone and service-ui scope can now respond to terminal.html: - If using standalone scope path/to/scope/ -> path/to/scope/terminal.html will be used. - If using service-ui app/instanceid -> app/instanceId/terminal.html
jpellizzari
reviewed
Oct 9, 2017
| @@ -243,7 +243,7 @@ class Terminal extends React.Component { | |||
|
|
|||
| const bcr = this.node.getBoundingClientRect(); | |||
| const minWidth = (this.state.characterWidth * 80) + (8 * 2); | |||
| openNewWindow(`${getApiPath()}/terminal.html#!/state/${paramString}`, bcr, minWidth); | |||
| openNewWindow(`${basePath(window.location.pathname)}/terminal.html#!/state/${paramString}`, bcr, minWidth); | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
@foot What is the context for this? I am confused as to what this is fixing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scope terminal.html route. Both standalone and service-ui scope can now
respond to terminal.html: