Make Time Travel a modular component #2888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbarl
force-pushed
the
make-time-travel-modular-component
branch
from
0c89171 to
742a8c5
Compare
…ime travel is contained in one component.
fbarl
changed the title
|
Still reviewing this one @fbarl I will try to finish up by the end of the day tomorrow (10/17) |
No worries @jpellizzari, this PR is not blocking any work at the moment. Forgot to mention what might be obvious, but nothing in Time Travel behaviour should have changed with this PR, it's a pure refactoring one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2893.
Changes
TimeTravelComponent, which communicates with the world only through forwarded props and is completely isolated from the Scope Redux state.styled-componentslibrary to contain all the Time Travel styles in the component.ui-componentsrepo separatelyAppcomponent into the theme the same way it's done inservice-uirepo, to start using more standardized colorset in Scope (note: I tried doing it inmain.jsandmain.dev.jsfiles instead, but that wouldn't work with local proxying soapp.jswas naturally my second choice).