simplify joinResults
#2994
Merged
simplify joinResults
#2994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixupAdjacencies fixes up adjancencies of mapped nodes. The nodes at the call sites we are removing aren't mapped.
Avoid a reduce step by joining the host topology in endpoints2Hosts. This is similar to what we do in connectionJoin and endpoints2Processes.
Instead of copying unmatched nodes at the end, and matched nodes when we encounter them, copy *all* nodes at the beginning.
Since we seed the joinResult with the nodes from the topology we are mapping to, we know the 'create' function is only called when there is no node with the specified id. This neatly makes the 'create' function only do what it says, i.e. return _new_ nodes.
Any existing list would be mutated by result(), which is bad. Note that all the existing newJoinResults() call sites pass in nodes with no adjacencies, so this is purely a safety measure.
bboreham
approved these changes
Dec 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bunch of refactoring, tidying up, simplification and a tiny bit of optimisation.