Close terminal pipe, when closing the pod panel #3045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moving `deletePipe()` in `componentWillUnmount()` ensures the pipe is deleted when: 1. the terminal is closed 2. the terminal is closed when closing the pod panel The pipe still does not get deleted when popping out the terminal.
foot
approved these changes
Feb 1, 2018
There was a problem hiding this comment.
Nice! As you say, when the popped out terminal is closed the pipe is not deleted. But I'm not sure if that's important.
If so we could add a window.addEventListener('unload') to tidy up, that would need a little more testing though I'm not 100% sure how that plays w/ inflight ajax etc.
LGTM as is though
Is that a leak? |
yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving
deletePipe()incomponentWillUnmount()ensures the pipe is deleted when:The pipe still does not get deleted when popping out the terminal. Created #3047.
Fixes #3035.