Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Time Travel at all times in Weave Cloud #3065

Merged
merged 2 commits into from
Feb 13, 2018
Merged

Conversation

fbarl
Copy link
Contributor

@fbarl fbarl commented Feb 9, 2018

Changes
  • Show Time Travel at all times if historic reports are supported (in particular in Weave Cloud) together with pause/live buttons, removing the Time Control live/pause/time travel buttons in the top right corner.
  • If historic reports are not supported, show only Time Control with live/paused buttons as before.

Scope in Weave Cloud
image

Scope standalone
image

@fbarl fbarl self-assigned this Feb 9, 2018
@rade
Copy link
Member

rade commented Feb 9, 2018

screenshot?

@fbarl fbarl changed the title [WIP] Always show Time Travel Show Time Travel at all times in Weave Cloud Feb 9, 2018
@fbarl fbarl requested a review from foot February 9, 2018 19:54
@fbarl fbarl force-pushed the always-show-time-travel branch from 554d033 to 165f3be Compare February 12, 2018 12:38
@foot
Copy link
Contributor

foot commented Feb 12, 2018

Minor aesthetical points:

  • The loading indicator looks a smidge awkward behind the top nav maybe bump it down a bit.
  • on 1440x and hosts+graph the cpu/memory/load is overlapped by details panel by ~10px which looks a tiny bit awkward
  • we've lost of a lot of vertical space! This will work better when top-nav moves to the side?

Copy link
Contributor

@foot foot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't get a chance to test in standalone / ohne-WC. But LGTM other than that

@fbarl
Copy link
Contributor Author

fbarl commented Feb 13, 2018

The loading indicator looks a smidge awkward behind the top nav maybe bump it down a bit.

Good catch! I centered it vertically.

On 1440px and hosts+graph the cpu/memory/load is overlapped by details panel by ~10px which looks a tiny bit awkward

Alright, I increased the top margin for the node details to avoid them overlapping.

We've lost of a lot of vertical space! This will work better when top-nav moves to the side?

Yes, hopefully after this PR is merged, we'll be incentivized to push with layout changes faster :)

@fbarl fbarl merged commit 2101a28 into master Feb 13, 2018
@fbarl fbarl deleted the always-show-time-travel branch February 13, 2018 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants