Minimal fix to make scope start with Docker for Mac again. #3140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@dglaubman found that recent versions of Docker for Mac (Docker version 18.03.0-ce, build 0520e24) don't write out ${HOME}/Library/Containers/com.docker.docker/Data/database any more. @foot confirmed this. A fresh installation of Docker for Mac (Version 18.03.0-ce-mac60 (23751), Channel: stable) did not create the file. The result was that installations which had this leftover file could start scope, whereas newer couldn't. The fix simply changes this check to a path which actually exists. Thanks @dglaubman and @foot for the analysis and confirmation. Fixes #3064
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dglaubman found that recent versions of Docker for Mac (Docker version 18.03.0-ce, build 0520e24) don't write out
${HOME}/Library/Containers/com.docker.docker/Data/databaseany more.@foot confirmed this. A fresh installation of Docker for Mac (Version 18.03.0-ce-mac60 (23751), Channel: stable) did not create the file.
The result was that installations which had this leftover file could start scope, whereas newer couldn't. The fix simply changes this check to a path which actually exists.
Thanks @dglaubman and @foot for the analysis and confirmation.
Fixes #3064