Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce theme font sizes #3167

Merged
merged 2 commits into from
May 11, 2018
Merged

Enforce theme font sizes #3167

merged 2 commits into from
May 11, 2018

Conversation

fbarl
Copy link
Contributor

@fbarl fbarl commented May 11, 2018

Resolves scope part of weaveworks/ui-components#202.

Font size distribution across scope:

17 - tiny
17 - small
11 - normal
 7 - large
 2 - extra large
 1 - huge

There was a strong bias towards really small font sizes compared to service-ui, so hopefully this will make Scope look a tiny bit more like Weave Cloud UI (although a lot of font sizes will require tiny tweaking after this PR, I'm sure).

@fbarl fbarl self-assigned this May 11, 2018
@fbarl fbarl requested review from jpellizzari and miklosp May 11, 2018 15:00
@fbarl fbarl merged commit 25415f7 into master May 11, 2018
@fbarl fbarl deleted the 202-theme-fonts branch May 11, 2018 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants