Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close xterm on exit #3172

Merged
merged 2 commits into from
May 14, 2018
Merged

Close xterm on exit #3172

merged 2 commits into from
May 14, 2018

Conversation

fbarl
Copy link
Contributor

@fbarl fbarl commented May 14, 2018

Resolves #3160.

Changes
  • Bumped xterm to version 3.3.0 to fix the cursor blinking option
  • Immediately close the terminal window when deleting the pipe

@fbarl fbarl self-assigned this May 14, 2018
@fbarl fbarl requested a review from lilic May 14, 2018 14:42
lilic
lilic approved these changes May 14, 2018
View reviewed changes
Copy link
Contributor

@lilic lilic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🎉Yay! Thanks for this!

Guess let's wait for tests to go 💚 :)

@fbarl fbarl merged commit e059845 into master May 14, 2018
@fbarl fbarl deleted the 3160-close-terminal-on-exit branch May 14, 2018 16:29
@lilic lilic mentioned this pull request May 17, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilic lilic lilic approved these changes

Assignees

@fbarl fbarl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typing exit in a terminal should close the pop up window
2 participants
@fbarl @lilic