Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check container is running before trying to open its namespace #3279

Merged
merged 1 commit into from
Aug 7, 2018
Merged

Check container is running before trying to open its namespace #3279

merged 1 commit into from
Aug 7, 2018

Conversation

bboreham
Copy link
Collaborator

@bboreham bboreham commented Jul 24, 2018 •
edited
Loading

Otherwise we get pointless errors logged in debug mode when we encounter dead containers.

satyamz
satyamz approved these changes Aug 7, 2018
View reviewed changes
Copy link
Contributor

@satyamz satyamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

qiell
qiell approved these changes Aug 7, 2018
View reviewed changes
Copy link
Contributor

@qiell qiell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bboreham bboreham merged commit 50a83b0 into master Aug 7, 2018
@bboreham bboreham deleted the check-pid branch January 13, 2020 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiell qiell qiell approved these changes

@satyamz satyamz satyamz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bboreham @satyamz @qiell