Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new Search component #3337

Merged
merged 4 commits into from
Sep 6, 2018
Merged

Use new Search component #3337

merged 4 commits into from
Sep 6, 2018

Conversation

fbarl
Copy link
Contributor

@fbarl fbarl commented Sep 3, 2018

Resolves #3314.

Transferring search context between Weave Cloud aspects is to be done in separate PRs.

@fbarl fbarl self-assigned this Sep 3, 2018
@fbarl fbarl force-pushed the 3314-use-new-search-bar branch from 14bcf84 to 3c6cced Compare September 4, 2018 12:12
@fbarl fbarl requested a review from foot September 4, 2018 12:15
@fbarl fbarl changed the title [WIP] Use new Search component Use new Search component Sep 4, 2018
Copy link
Contributor

@foot foot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one.

Only issue: new default behaviour of cmp/Search is to pin items onBlur. I think this feels quite strange when you: filter > click a node > close > topo is filtered w/ pin and everything has disappeared.

transition: transform 0.3s 0s ease-in-out, opacity 0.3s 0s ease-in-out;
text-align: left;
padding: 0 1em;
opacity: 0;

This comment was marked as abuse.

@fbarl
Copy link
Contributor Author

fbarl commented Sep 5, 2018

Only issue: new default behaviour of cmp/Search is to pin items onBlur. I think this feels quite strange when you: filter > click a node > close > topo is filtered w/ pin and everything has disappeared.

That's a good point - as discussed, we can resolve this with weaveworks/ui-components#365.

@fbarl fbarl merged commit 69d1c6e into master Sep 6, 2018
@fbarl fbarl deleted the 3314-use-new-search-bar branch September 6, 2018 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants