Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: improve the warning about opening Scope to the Internet #3650

Merged
merged 4 commits into from
Jul 31, 2019

Conversation

bboreham
Copy link
Collaborator

@bboreham bboreham commented Jul 9, 2019

Trying to improve the situation at #3624 and #2814

Also drive-by removal of boot2docker since it's ancient history and complicates the instructions.

@bboreham bboreham requested a review from qiell as a code owner July 9, 2019 12:21
@bboreham bboreham changed the title Warn open port Docs: improve the warning about opening Scope to the Internet Jul 16, 2019
Copy link
Contributor

@qiell qiell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

README.md Outdated
@@ -42,15 +42,16 @@ If you would like to see your name added, let us know on Slack, or send a PR ple

## <a name="getting-started"></a>Getting Started

Ensure your computer is behind a firewall that blocks port 4040 then,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a small note like, If you're using Scope in Kubernetes then do not expose it as a NodePort service ?

Also, it'd be good to have these instructions in bold format. 😄

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Contributor

@satyamz satyamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@satyamz satyamz merged commit 5313209 into master Jul 31, 2019
@bboreham bboreham deleted the warn-open-port branch September 13, 2019 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants