-
Notifications
You must be signed in to change notification settings - Fork 712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: improve the warning about opening Scope to the Internet #3650
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
README.md
Outdated
@@ -42,15 +42,16 @@ If you would like to see your name added, let us know on Slack, or send a PR ple | |||
|
|||
## <a name="getting-started"></a>Getting Started | |||
|
|||
Ensure your computer is behind a firewall that blocks port 4040 then, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a small note like, If you're using Scope in Kubernetes then do not expose it as a NodePort service ?
Also, it'd be good to have these instructions in bold format. 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Trying to improve the situation at #3624 and #2814
Also drive-by removal of
boot2docker
since it's ancient history and complicates the instructions.