-
Notifications
You must be signed in to change notification settings - Fork 712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update javascript libraries in various places #3685
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@fbarl Can you advise on the update for the CI related bits? |
So, the UI image that CircleCI currently uses is I'm not sure this is the best way to proceed but what we could do for sure is:
This doesn't sound like the optimal approach though and I wonder if @bboreham knows of any better way to proceed. If not, we could follow those 3 steps above and get it out of the way. |
The change to use specific tags for CircleCI build image was in #3333, but I can't see that I explained it very well. |
Checklist (suggested by @bboreham):
|
Going to merge this PR after #3689 is merged. |
keep eslint-config-airbnb version, newer version requires changes in our code
Update javascript libraries in various places, needs newer node.