Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop pipe operations after EOF #3784

Merged
merged 2 commits into from
May 7, 2020
Merged

Stop pipe operations after EOF #3784

merged 2 commits into from
May 7, 2020

Commits on May 6, 2020

  1. fix (pipes): check websocket errors inside CopyToWebsocket() 

    Previously we were treating EOF on the reader as no-error, meaning
that operations like Kubernetes Describe would retry endlessly when
finished.
    @bboreham
    bboreham committed May 6, 2020
    Configuration menu
    Copy the full SHA
    323aa46 View commit details
    Browse the repository at this point in the history

  2. fix (pipes): silence EOF error 

    This comes back when an operation like Kubernetes Describe finishes;
hide it so we don't print as an error.
    @bboreham
    bboreham committed May 6, 2020
    Configuration menu
    Copy the full SHA
    24197bc View commit details
    Browse the repository at this point in the history