Tag containers with WeaveDNS hostnames. #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomwilkie
force-pushed
the
weave-dns-hostnames
branch
2 times, most recently
from
c0352a9 to
2623670
Compare
| @@ -26,27 +29,37 @@ const ( | |||
| // overlay -- though I'm not sure what that would look like in practice right | |||
| // now. | |||
| type Weave struct { | |||
| url string | |||
| url string | |||
| scope string | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
tomwilkie
force-pushed
the
weave-dns-hostnames
branch
from
2623670 to
5a86014
Compare
|
@peterbourgon PTAL |
| if entry.Tombstone > 0 { | ||
| continue | ||
| } | ||
| nodeid := report.MakeContainerNodeID(w.hostID, entry.ContainerID) |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
Are we sure it's OK to make an HTTP call from the probe to the Weave router with every Tag and Report, i.e. once per publish interval? |
tomwilkie
force-pushed
the
weave-dns-hostnames
branch
from
5a86014 to
e9fad61
Compare
|
Yes I'm pretty confident this is safe; everything we're querying is in memory, and the weave routers deals with many more QPS on other interfaces (ie DNS). Lets put it another way: I'm more confident this is safe than the amount of queries we do on the docker daemon! |
|
👍 |
tomwilkie
added a commit
that referenced
this pull request
Aug 25, 2015
Tag containers with WeaveDNS hostnames.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.