Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix react key warning #672

Merged
merged 4 commits into from
Nov 16, 2015
Merged

Fix react key warning #672

merged 4 commits into from
Nov 16, 2015

Conversation

davkal
Copy link
Contributor

@davkal davkal commented Nov 13, 2015

  • one in TopologyOptions
  • and some in details panel, @tomwilkie need report for that

@tomwilkie
Copy link
Contributor

I still get a few Warning: Sparkline.getDOMNode(...) is deprecated. Please use ReactDOM.findDOMNode(instance) instead., but otherwise this does indeed fix the react warnings. LGTM.

@tomwilkie tomwilkie assigned bboreham and davkal and unassigned bboreham Nov 16, 2015
@davkal
Copy link
Contributor Author

davkal commented Nov 16, 2015

Sparkline.getDOMNode(...) is deprecated is gone. Maybe you needed to rebuild.

davkal added a commit that referenced this pull request Nov 16, 2015
@davkal
Merge pull request #672 from weaveworks/react-key-warning
8980f6c 
Fix react key warning
@davkal davkal merged commit 8980f6c into master Nov 16, 2015
@davkal davkal deleted the react-key-warning branch November 16, 2015 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@davkal davkal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davkal @tomwilkie @bboreham