Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter nodes that are only connected to themselves. #706

Merged
merged 1 commit into from
Dec 1, 2015

Conversation

tomwilkie
Copy link
Contributor

Fixes #656

@davkal
Copy link
Contributor

davkal commented Dec 1, 2015

It works. But then there is no options to show unconnected nodes. The option has no action. I think if we filter nodes we should allow to unset the filter.

screen shot 2015-12-01 at 15 58 30

@tomwilkie
Copy link
Contributor Author

This is on the Applications view? We decide a while back not to add a filter for that as there would be too many processes in the show-unconnected state. Either way, do you mind filing a separate issue for this? With the recent improvements in the rendering engine this is something we could revisit.

@davkal
Copy link
Contributor

davkal commented Dec 1, 2015

Added #713 for the missing option. Otherwise LGTM

@tomwilkie
Copy link
Contributor Author

Thanks!

tomwilkie added a commit that referenced this pull request Dec 1, 2015
Filter nodes that are only connected to themselves.
@tomwilkie tomwilkie merged commit 00e63e8 into master Dec 1, 2015
@tomwilkie tomwilkie deleted the 656-unconnected branch December 1, 2015 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants